Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: Add pagination to core concepts/indexes #1766

Merged
merged 13 commits into from
Jul 4, 2022
Merged

v0.28: Add pagination to core concepts/indexes #1766

merged 13 commits into from
Jul 4, 2022

Conversation

maryamsulemani97
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 commented Jun 30, 2022 •
edited
Loading

Adds the pagination index setting to:
-learn/core_concepts/indexes.md
-learn/configuration/settings.md

@maryamsulemani97 maryamsulemani97 added this to the v0.28 milestone Jun 30, 2022
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review June 30, 2022 10:58
@guimachiavelli guimachiavelli mentioned this pull request Jun 30, 2022
Closed
17 tasks
guimachiavelli
guimachiavelli reviewed Jun 30, 2022
View reviewed changes
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
learn/core_concepts/indexes.md Outdated Show resolved Hide resolved
@guimachiavelli guimachiavelli changed the title Add pagination to core concepts/indexes v0.28: Add pagination to core concepts/indexes Jun 30, 2022
maryamsulemani97 and others added 2 commits June 30, 2022 15:23
@maryamsulemani97 @guimachiavelli
Update learn/core_concepts/indexes.md
0a340c2 
Co-authored-by: gui machiavelli <gui@meilisearch.com>
@maryamsulemani97
Update indexes.md
752f0b3
@maryamsulemani97 maryamsulemani97 mentioned this pull request Jul 4, 2022
Closed
guimachiavelli
guimachiavelli approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, but adding to returns to the end of the code samples/samples template files because GH complains about it otherwise.

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.vuepress/public/sample-template.yaml Outdated Show resolved Hide resolved
@guimachiavelli
Copy link
Member

bors merge

bors bot added a commit that referenced this pull request Jul 4, 2022
@bors @maryamsulemani97 @guimachiavelli
Merge #1766
70112d7 
1766: v0.28: Add pagination to core concepts/indexes r=guimachiavelli a=maryamsulemani97

Adds the pagination index setting to:
-`learn/core_concepts/indexes.md`
-`learn/configuration/settings.md`

Co-authored-by: Maryam Sulemani <maryam@meilisearch.com>
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: gui machiavelli <hey@guimachiavelli.com>
@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Build failed:

@guimachiavelli guimachiavelli changed the base branch from v0.28-pagination to v0.28-pagination-settings July 4, 2022 11:04
@guimachiavelli
Copy link
Member

Had to change base to address missing link, merge conflicts

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Build succeeded:

@bors bors bot merged commit 16b334d into v0.28-pagination-settings Jul 4, 2022
@bors bors bot deleted the update-indexes.md-to-add-pagination branch July 4, 2022 11:10
This was referenced Jul 6, 2022
Merged
Merged
@bidoubiwa bidoubiwa mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guimachiavelli guimachiavelli guimachiavelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging this pull request may close these issues.
2 participants
@maryamsulemani97 @guimachiavelli