-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contextual links to demos #2649
Conversation
How to see the preview of this PR?Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:add-demos Credentials to access the page are in the company's password manager as "Docs deploy preview". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are unfortunately required to use the official GitHub spelling. It's clumsy, but 🤷
Also, as I mention in my comment, I'm not big on the idea of adding new sections to the reference pages. They have a fairly strict structure so users can find info quickly.
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Co-authored-by: gui machiavelli <gui@meilisearch.com>
Hello, For simplicity, I approved your changes removing the demo in reference. However, do you have another page to recommend to include this link? It's the only one I found that focuses on multi-search, and the laravel demo is the only that showcase multi search :( |
Hmmm…good point. The only other place we mention multi-search is the Meilisearch overview. Perhaps we could add it there for the moment? It's not ideal, but it's one of the most visited docs pages. In the future I'd like to have a simple multi-search guide which would be the ideal place for a demo link, but I really can't give you anything resembling a timeline right now. |
I'm happy to merge as-is and consider where to include that link in a future PR. Feel free to merge whenever possible 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, lost sight of this for the past couple of weeks.
Merging!
Pull Request
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!