Prefer MEILISEARCH_URL over localhost:7700
#3083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to see the preview of this PR?Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:use-meilisearch-url-placeholder Credentials to access the page are in the company's password manager as "Docs deploy preview". |
|
@guimachiavelli there is git conflict in the file |
| @@ -59,7 +59,7 @@ Next, enable the vector store experimental feature: | |||
|
|
|||
| ```sh | |||
| curl \ | |||
| -X PATCH 'http://localhost:7700/experimental-features/' \ | |||
| -X PATCH 'https://MEILISEARCH_URL/experimental-features/' \ | |||
There was a problem hiding this comment.
Hi @guimachiavelli when you use the notation _URL in the end of the env var I already expect it to contain the https/http (protocol) in it. Otherwise we would be using _HOST or _DOMAIN.
https://stackoverflow.com/questions/9260218/parts-of-a-url-host-port-path
There was a problem hiding this comment.
Good catch bruno! My bad on it, Bruno is right on this one from my point of view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the continuous effort in rendering the docs less focussed on self-hosted instances.
@curquiza, this is the PR we spoke about changing all the target URL for all code samples. I'll only merge it after my return in the new year, so there's no rush as far as SDK code samples go. All changes relevant for the integrations team are in
.code-samples.meilisearch.yaml—you can safely ignore the other 19 files touched by this PR.