Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release changelogs for v0.28.0 #13

Merged
merged 84 commits into from
Jul 11, 2022
Merged

Add release changelogs for v0.28.0 #13

merged 84 commits into from
Jul 11, 2022

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jun 7, 2022

Here are the huge changelogs for the v0.28.0 release

⚠️ Should NOT be merged before the official v0.28.0 release is out!

meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
curquiza and others added 5 commits June 8, 2022 09:56
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my first time editing a release changelog in a while, so I wasn't sure if I should edit things like the header levels.

On the docs we try never to use multiple H1s in the same article, or to skip a header number (i.e. don't jump from H1 to H3). But this may be an aspect of your template, so feel free to ignore those particular suggestions.

meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Outdated Show resolved Hide resolved
meilisearch-release-changelogs/v0.28.0.md Show resolved Hide resolved
curquiza and others added 2 commits June 8, 2022 18:50
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
curquiza and others added 17 commits June 8, 2022 19:01
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
dichotommy
dichotommy previously approved these changes Jun 9, 2022
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
@curquiza curquiza requested a review from gmourier June 9, 2022 16:47
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
@gmourier
Copy link
Member

Waiting for the last naming changes if needed on meilisearch/specifications#157 before giving a final review. Other than that, everything looks great to me!

@curquiza
Copy link
Member Author

curquiza commented Jun 14, 2022

@gmourier I let this PR open until the official v0.28.0 is out. I've updated the PR description to make my expectations clearer

Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
Copy link
Member

@gmourier gmourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +7 to +8
<!-- The following line should NOT be put in the official release changelogs -->
⚠️ Since this is a release candidate (RC), the official documentation is not updated yet, but will be ready for the official v0.28.0 release. The work-in-progress documentation is available [here]().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- The following line should NOT be put in the official release changelogs -->
⚠️ Since this is a release candidate (RC), the official documentation is not updated yet, but will be ready for the official v0.28.0 release. The work-in-progress documentation is available [here]().

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can remove it directly from github before the release 🤓

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not remove it from this PR, so that I can copy/paste in my next release changelog
However I will not put it in the v0.28.0 changelog on Monday haha

@curquiza curquiza requested a review from gmourier July 7, 2022 17:47
@curquiza curquiza merged commit 690597d into main Jul 11, 2022
@curquiza curquiza deleted the release-v0.28.0 branch July 11, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants