Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lifetime to ReservedSpace (closes #258) #259

Merged
merged 1 commit into from
May 1, 2024
Merged

add lifetime to ReservedSpace (closes #258) #259

merged 1 commit into from
May 1, 2024

Conversation

nolanderc
Copy link
Contributor

Pull Request

Related issue

Fixes #258

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@nolanderc nolanderc marked this pull request as ready for review May 1, 2024 09:14
Kerollmops
Kerollmops approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed much better! Thank you. I am still wondering if it is a breaking change, I would say no 🤔

@Kerollmops Kerollmops merged commit 0fb9f75 into meilisearch:main May 1, 2024
8 checks passed
@Kerollmops Kerollmops added this to the v0.20.1 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.1
Development

Successfully merging this pull request may close these issues.

ReservedSpace is unsound due to not being bound to its origin transaction.
2 participants
@nolanderc @Kerollmops