Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MeiliSearch v0.15.0 #43

Closed
10 of 12 tasks
bidoubiwa opened this issue Sep 24, 2020 · 3 comments
Closed
10 of 12 tasks

Bump MeiliSearch v0.15.0 #43

bidoubiwa opened this issue Sep 24, 2020 · 3 comments
Assignees
Labels
need vote When several solutions are suggested

Comments

@bidoubiwa
Copy link
Contributor

bidoubiwa commented Sep 24, 2020

HTTP changes in new MeiliSearch release

Feel free to check the boxes if the changes do not apply to the suggested SDK.

Facet Distributions changes

Link: meilisearch/meilisearch#944

Routes impacted:

  • facetsDistribution in a search query /indexes/test/search?facetsDistribution=%5B%22color%22%5D

This apply only to SDKs that made specific tests on facetDistributions should test if they are not breaking with the new MeiliSearch version.

This PR has been reverted

Fields are now sorted with consistency

Link: Sort fields without consistency in lexicographical order meilisearch/meilisearch#943

Routes impacted:

  • displayedAttributes in GET /index/:uid:/settings and GET /index/:uid:/settings/displayed-attributes routes
  • facetsDistribution in a search query /indexes/test/search?facetsDistribution=%5B%22color%22%5D
    SDK's that used to "sort" the return of MeiliSearch before making the test should remove the sort function.

This impact only SDKs that still have tests that sorts responses from MeiliSearch

This issue is not ready for this version

Remove update health

Link: Refactor /health route meilisearch/meilisearch#940

The update health route should be removed from every SDK

This issue is not ready for this version

Dumps (old name: Backups)

link: Dump Meilisearch DataBase triggering an HTTP route meilisearch/meilisearch#840 & dump meilisearch/meilisearch#887

cf #44

Lazely create an index

// Will be discussed in another issue

This issue is not ready for this version

Empty string returns placeholer search

link: Considere an empty query search as a placeholder search meilisearch/meilisearch#916

For SDKs that tested an empty string as a query to verify that MeiliSearch returns an empty string, tests must be changed.

SDKs:

  • meilisearch-go
  • meilisearch-js
  • meilisearch-php
  • meilisearch-python
  • meilisearch-ruby
  • meilisearch-swift
  • meilisearch-rust
  • meilisearch-java
  • meilisearch-net
  • instant-meilisearch
  • docs-searchbar.js
  • vuepress-plugin-meilisearch
@bidoubiwa bidoubiwa added the need vote When several solutions are suggested label Sep 24, 2020
@curquiza
Copy link
Member

I updated the issue according to the pre-release content.

Moral of the story: not to create this kind of issue until the pre-release is out 😂

@bidoubiwa
Copy link
Contributor Author

Absolutely, point taken haha 😂

@curquiza
Copy link
Member

curquiza commented Dec 2, 2020

I'm closing this issue since all the SDKs handle placeholder search and the dumps feature has already an issue in this repo #44

@curquiza curquiza closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need vote When several solutions are suggested
Projects
None yet
Development

No branches or pull requests

3 participants