Considere an empty query search as a placeholder search #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice rust-fmt haha |
|
I now use VSCode with a rust-analyzer 😉 |
|
Could you please split the rustfmt thing from the core change you've done? It would be easier to review. |
qdequele
added a commit
that referenced
this pull request
Aug 17, 2020
qdequele
force-pushed
the
placeholder-search-on-empty-string
branch
from
64a3498
to
7430776
Compare
Kerollmops
requested changes
Sep 21, 2020
qdequele
added a commit
that referenced
this pull request
Sep 21, 2020
qdequele
force-pushed
the
placeholder-search-on-empty-string
branch
from
7430776
to
b17c734
Compare
This was referenced Sep 22, 2020
Kerollmops
previously approved these changes
Sep 25, 2020
|
bors r+ |
|
@qdequele Whoops there is a merge conflict, could you rebase, please? |
|
Merge conflict. |
qdequele
force-pushed
the
placeholder-search-on-empty-string
branch
from
b17c734
to
51fd849
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #856; Relative tracking issue: #729