Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken cropLength test in search_test.dart #155

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix broken cropLength test in search_test.dart #155

merged 1 commit into from
May 4, 2022

Conversation

brunoocasali
Copy link
Member

Fix a test broken after the upgrade to v0.27.0

@brunoocasali brunoocasali added the skip-changelog The PR will not appear in the release changelogs label May 4, 2022
@brunoocasali brunoocasali requested review from alallema and bidoubiwa May 4, 2022 02:53
alallema
alallema approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌯

@brunoocasali brunoocasali merged commit 968fcc1 into bump-meilisearch-v0.27.0 May 4, 2022
@brunoocasali brunoocasali deleted the fix-old-tests branch May 4, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

@bidoubiwa bidoubiwa Awaiting requested review from bidoubiwa

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoocasali @alallema