Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom csv delimiter #295

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Support for custom csv delimiter #295

merged 1 commit into from
Apr 28, 2023

Conversation

ahmednfwela
Copy link
Collaborator

Pull Request

Related issue

Fixes #292

What does this PR do?

  • Adds csvDelimiter parameter to addDocumentsCsv, addDocumentsCsvInBatches, updateDocumentsCsv, updateDocumentsCsvInBatches
  • Adds tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

cc @brunoocasali

@brunoocasali brunoocasali added the enhancement New feature or request label Apr 28, 2023
brunoocasali
brunoocasali approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work as usual @ahmednfwela 🎉

@brunoocasali
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 28, 2023

Build succeeded:

@bors bors bot merged commit 3505e83 into meilisearch:main Apr 28, 2023
@ahmednfwela ahmednfwela deleted the csv-delimiter-#292 branch April 28, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure the CSV delimiter when updating documents
2 participants
@ahmednfwela @brunoocasali