Raise min Dart SDK to 3.0.0 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can go for the v3 directly after v1.2 :) |
|
great! Should I base all coming v1.2 PRs on this PR then? |
|
Hi @ahmednfwela you can update your PR to make it points to v3 of Dart, then we can release it alone, and you can base the v1.2 PRs in the bump as usual (I will rebase the bump with main). |
|
@brunoocasali I updated the PR to raise the min sdk version to v3.0.0 |
brunoocasali
added
the
breaking-change
brunoocasali
approved these changes
May 17, 2023
meili-bors bot
added a commit
that referenced
this pull request
May 17, 2023
307: Raise min Dart SDK to 3.0.0 r=brunoocasali a=ahmednfwela # Pull Request ## What does this PR do? - Raise the minimum dart sdk to 3.0.0, this lets us use the [super parameters](https://dart.dev/language/constructors#super-parameters) feature, class modifiers, records and patterns ## PR checklist Please check if your PR fulfills the following requirements: - [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Ahmed Fwela <ahmednfwela@bdaya-dev.com>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"2 of 4 required status checks are expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!