Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to the facet setting customization at the index level #295

Closed
5 tasks
brunoocasali opened this issue Jul 16, 2022 · 0 comments · Fixed by #339
Closed
5 tasks

Add support to the facet setting customization at the index level #295

brunoocasali opened this issue Jul 16, 2022 · 0 comments · Fixed by #339
Labels
good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

⚠️ This issue is generated, which means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, please add any clarification and instructions about this issue.

Related to:

Add a faceting index settings resource to manage customization of the maximum value per facet.

  • Expose faceting object on /indexes/:index_uid/settings endpoints.
  • Add GET/PATCH/DELETE - /indexes/:index_uid/settings/faceting endpoints.

The faceting object definition is made of the following properties:

  • maxValuesPerFacet type (int)

More information about what each field does could be checked in the spec.

Check the other customization methods for reference like: synonyms, searchableAttributes, filterableAttributes.

TODO:

  • Add the new methods to customize faceting
    • GET /indexes/:index_uid/settings/faceting
    • PATCH /indexes/:index_uid/settings/faceting
    • DELETE /indexes/:index_uid/settings/faceting
  • Add tests
@brunoocasali brunoocasali added the good first issue Good for newcomers label Jul 16, 2022
@juchom juchom mentioned this issue Oct 4, 2022
Merged
3 tasks
bors bot added a commit that referenced this issue Oct 6, 2022
@bors @juchom @alallema
Merge #327
288a27c 
327: Add code samples for documentation r=alallema a=juchom

# Pull Request

## Related issue
Fixes #19 

## What does this PR do?
- Add missing code samples for meilisearch documentation
- Fix GetStats method to GetStatsAsync
- Fix a typo

Missing samples will be added when #294 #295 will be implemented

## PR checklist
Please check if your PR fulfills the following requirements:
- [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [X] Have you read the contributing guidelines?
- [X] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Julien Chomarat <j.chomarat@linoa.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
@alrz1999 alrz1999 mentioned this issue Oct 9, 2022
Merged
3 tasks
@bors bors bot closed this as completed in b51d8ff Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add faceting settings alrz1999/meilisearch-dotnet
2 participants
@brunoocasali @alallema