Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typo Tolerance settings #263

Merged
merged 4 commits into from
May 18, 2022

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented May 17, 2022

Add new methods to handle the typo tolerance settings from an Index setting.

@brunoocasali brunoocasali added the enhancement New feature or request label May 17, 2022
@brunoocasali brunoocasali requested a review from alallema May 17, 2022 08:48
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!!! 🔥

@@ -373,3 +373,53 @@ tenant_token_guide_generate_sdk_1: |-
tenant_token_guide_search_sdk_1: |-
frontEndClient = new MeilisearchClient("http://127.0.0.1:7700", token);
SearchResult<Patient> searchResult = await frontEndClient.Index("patient_medical_records").SearchAsync<Patient>("blood test");
get_typo_tolerance_1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UpdateSetting method doesn't exist in dotnet right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand your question, but I realized that I missed the suffix "Async" :)

src/Meilisearch/Settings.cs Outdated Show resolved Hide resolved
src/Meilisearch/TypoTolerance.cs Outdated Show resolved Hide resolved
src/Meilisearch/TypoTolerance.cs Outdated Show resolved Hide resolved
src/Meilisearch/TypoTolerance.cs Outdated Show resolved Hide resolved
src/Meilisearch/TypoTolerance.cs Outdated Show resolved Hide resolved
@brunoocasali brunoocasali requested a review from alallema May 17, 2022 14:59
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥖

@brunoocasali brunoocasali merged commit 5f0a865 into bump-meilisearch-v0.27.0 May 18, 2022
@brunoocasali brunoocasali deleted the add-typo-tolerance branch May 18, 2022 08:30
bors bot added a commit that referenced this pull request May 18, 2022
265: Update version for the next release (v0.10.2) r=brunoocasali a=brunoocasali

This version makes this package compatible with Meilisearch v0.27.0 🎉 
Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information about the changes.

## 🚀 Enhancements

- Add new methods for the new typo tolerance settings (#263) `@brunoocasali`
`GetTypoToleranceAsync()` 
`UpdateTypoToleranceAsync(TypoTolerance typoTolerance)`  
`ResetTypoTolerance()`  
- Ensure nested field support (#260) `@brunoocasali` 
- Add new search parameters `highlightPreTag`, `highlightPostTag` and `cropMarker` (#258) `@brunoocasali` 

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants