-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Total tasks in task route #490
Add Total tasks in task route #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kashifsoofi
Can you add a test for this?
None of the other PRs adding this field has a test to check this field, maybe the server is not returing it? |
@kashifsoofi this PR contains tests meilisearch/meilisearch-dart#343 |
Maybe we are missing tests about the other fields for this repo. In any case we need to add some 😊 |
yes tests can be added to this function meilisearch-dotnet/tests/Meilisearch.Tests/TaskInfoTests.cs Lines 65 to 71 in d0193c4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! @kashifsoofi 🤘
bors merge
490: Add Total tasks in task route r=brunoocasali a=kashifsoofi # Pull Request ## Related issue Fixes #462 ## What does this PR do? - Added Total Tasks in task route ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 504: Bump xunit.runner.visualstudio from 2.5.3 to 2.5.4 r=brunoocasali a=dependabot[bot] Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.3 to 2.5.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/b9eacec401591bf17d5a3a5436223045c980562e"><code>b9eacec</code></a> v2.5.4</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/316c225a721e952c98ee36fbd722c2859ff3847e"><code>316c225</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/9d3aaa076f1c5596dd5aed68941aef6ca9657c55"><code>9d3aaa0</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/da1033b99db9ae1debee355466a031081540dd78"><code>da1033b</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/8b760896810eb16a3a55c30a3ee63739ff84a1eb"><code>8b76089</code></a> Remove unnecessary global.json</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/af8f8dfd4ffc32c25a81c2dd3e427658f4c63696"><code>af8f8df</code></a> Sort Directory.Build.props</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/44114d063aae1b4c40d7dd64e378d4151f17f949"><code>44114d0</code></a> Disable MSBuild transitive copies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/48b0558eadbee6b79379b2ad988ab5940882ef27"><code>48b0558</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/2b7d93036611a5026efe1b5cb90df7290a396f0b"><code>2b7d930</code></a> Updated README</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/097b60584fb932d3dcff297de827c543c879c7f4"><code>097b605</code></a> Move load failure messages from DiaSession and friends to internal diagnostic...</li> <li>Additional commits viewable in <a href="https://github.com/xunit/visualstudio.xunit/compare/2.5.3...2.5.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xunit.runner.visualstudio&package-manager=nuget&previous-version=2.5.3&new-version=2.5.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Kashif Soofi <kashif.soofi+git@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors merge |
490: Add Total tasks in task route r=brunoocasali a=kashifsoofi # Pull Request ## Related issue Fixes #462 ## What does this PR do? - Added Total Tasks in task route ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Kashif Soofi <kashif.soofi+git@gmail.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Pull Request
Related issue
Fixes #462
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!