Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination settings #328

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Add pagination settings #328

merged 2 commits into from
Jul 25, 2022

Conversation

GoryMoon
Copy link
Contributor

Pull Request

What does this PR do?

Fixes #325

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

alallema
alallema reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GoryMoon for this PR!
Very nice work 🎉 I just had a suggestion. Thanks to contribute to Meilisearch ❤️

types.go Outdated Show resolved Hide resolved
alallema
alallema approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 25, 2022

Build succeeded:

@bors bors bot merged commit 9236b8f into meilisearch:main Jul 25, 2022
@GoryMoon GoryMoon deleted the 325-support-pagination-setting branch July 25, 2022 09:14
@alallema alallema added the enhancement New feature or request label Jul 25, 2022
@GoryMoon GoryMoon mentioned this pull request Jul 25, 2022
Merged
bors bot added a commit that referenced this pull request Jul 26, 2022
@bors @GoryMoon
Merge #330
c5a7804 
330: Add pagination setting code samples and fix code sample typos r=alallema a=GoryMoon

Based on the comments from #329 this adds code samples for the pagination settings added in #328.

It also includes some typo fixes from the additions in #294.


Co-authored-by: GoryMoon <gurreja@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the pagination setting customization at the index level
2 participants
@GoryMoon @alallema