Add cancel task api for v0.30.0 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
add_cancel_task_api_for_v0.30.0
branch
from
d6bad58 to
478217b
Compare
brunoocasali
approved these changes
Dec 7, 2022
brunoocasali
requested changes
Dec 7, 2022
Comment on lines
+165
to
+174
| type CancelTasksQuery struct { | ||
| UIDS []int64 | ||
| IndexUIDS []string | ||
| Statuses []string | ||
| Types []string | ||
| BeforeEnqueuedAt time.Time | ||
| AfterEnqueuedAt time.Time | ||
| BeforeStartedAt time.Time | ||
| AfterStartedAt time.Time | ||
| } |
There was a problem hiding this comment.
Suggested change
| type CancelTasksQuery struct { | |
| UIDS []int64 | |
| IndexUIDS []string | |
| Statuses []string | |
| Types []string | |
| BeforeEnqueuedAt time.Time | |
| AfterEnqueuedAt time.Time | |
| BeforeStartedAt time.Time | |
| AfterStartedAt time.Time | |
| } | |
| type CancelTasksQuery struct { | |
| UIDS []int64 | |
| IndexUIDS []string | |
| Statuses []string | |
| Types []string | |
| BeforeEnqueuedAt time.Time | |
| AfterEnqueuedAt time.Time | |
| BeforeStartedAt time.Time | |
| AfterStartedAt time.Time | |
| BeforeFinishedAt time.Time | |
| AfterFinishedAt time.Time | |
| } |
There was a problem hiding this comment.
I didn't add those two filters because they didn't make sense, and they are not in the parameters available in the documentation. Are you sure it's a good think to add it?
| BeforeStartedAt: param.BeforeStartedAt, | ||
| AfterStartedAt: param.AfterStartedAt, | ||
| } | ||
| encodeTasksQuery(paramToSend, &req) |
There was a problem hiding this comment.
Can you make this function encodeTasksQuery support multiple sets of params?
There was a problem hiding this comment.
Not really, I could put interface{} as a parameter instead of a typed struct, but I wouldn't have access to the fields easily.
Add delete task api for v0.30.0
…30.0 Add swap indexes api for v0.30.0
alallema
force-pushed
the
add_cancel_task_api_for_v0.30.0
branch
from
27db98e to
a55baa0
Compare
bors bot
added a commit
that referenced
this pull request
Dec 14, 2022
382: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Done: - #390 - #392 - #395 - #396 - #397 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Dec 15, 2022
398: Update version for the next release (0.22.0) r=alallema a=alallema This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - New `pagination` strategy with the search parameters `Page` and `HitsPerPage` #392 - New filters on `GetTasks`: `UID`, `BeforeEnqueuedAt`, `AfterEnqueuedAt`, ... see #390 - New `client.CancelTasks` method that lets you cancel `enqueued` and `processing` tasks #395 - New `client.DeleteTasks` method that lets you delete tasks #396 - New `client.SwapIndexes` method that lets you swap two indexes #397 - New fields on `Task.Details` #395 ##⚠️ Breaking change - Parameters on `GetTasks` name changes: #390 - `Status` -> `Statuses` - `IndexUID` -> `IndexUIDS` - `Type` -> `Types` Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cancel task api see spec: meilisearch/specifications#195
TaskstructurecanceledByTaskInfostructureStatus,Type,TaskUID,IndexUIDandEnqueuedAtare no longer optional.CancelTasks()in the clientTasksQueryTaskInfoTasks.Detailsfields: