Configure Csv delimiter #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter tests are failing |
alallema
force-pushed
the
csv-delimiter
branch
3 times, most recently
from
f7cb103 to
a858022
Compare
bidoubiwa
reviewed
Mar 28, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return resp, nil | ||
| } | ||
|
|
||
| func (i Index) saveDocumentsFromReaderInBatches(documents io.Reader, batchSize int, documentsCsvFunc func(recs []byte, pk ...string) (resp *TaskInfo, err error), primaryKey ...string) (resp []TaskInfo, err error) { | ||
| func (i Index) saveDocumentsFromReaderInBatches(documents io.Reader, batchSize int, documentsCsvFunc func(recs []byte, op *CsvDocumentsQuery) (resp *TaskInfo, err error), options *CsvDocumentsQuery) (resp []TaskInfo, err error) { |
There was a problem hiding this comment.
Is this method only used for CSV?
There was a problem hiding this comment.
Yes, that why there is documentsCsvFunc in the parameters too
There was a problem hiding this comment.
Ok! It was not very clear per the function name
alallema
added
the
breaking-change
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
427: Update version for the next release (v0.24.0) r=bidoubiwa a=meili-bot This version makes this package compatible with Meilisearch v1.1 🎉 Check out the changelog of [Meilisearch v1.1](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ## 🐛 Bug Fixes - Fills the client field for each index entry returned by GetIndexes (#426) `@candiduslynx` ##⚠️ Breaking changes - Add the ability to provide a specific `csv-delimiter` when adding and updating documents in CSV format (#424) `@alallema` - New type `CsvDocumentsQuery{}` - Changed `AddDocumentsCsv()` which takes `CsvDocumentsQuery` as a parameter instead of a `...string` - Changed `AddDocumentsCsvInBatches()` which takes `CsvDocumentsQuery` as a parameter instead of a `...string` - Changed `UpdateDocumentsCsv()` which takes `CsvDocumentsQuery` as a parameter instead of a `...string` - Changed `UpdateDocumentsCsvInBatches()` which takes `CsvDocumentsQuery` as a parameter instead of a `...string` ## 🚀 Enhancements - Add FacetStats field in SearchResponse (#423) `@alallema` - New method `client.MultiSearch()` provides the possibility to make multiple requests at once (#422) `@alallema` Example: ```go client.MultiSearch(&MultiSearchRequest{ Queries: []SearchRequest{ { IndexUID: "movies", Query: "pooh", Limit: 5, }, { IndexUID: "movies", Query: "nemo", Limit: 5, }, { IndexUID: "movie_ratings", Query: "us", }, }, }) ``` Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
418: Changes related to the next Meilisearch release (v1.1.0) r=bidoubiwa a=meili-bot Related to this issue: meilisearch/integration-guides#251 This PR: - gathers the changes related to the next Meilisearch release (v1.1.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.1.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.1.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Done: - #422 - #423 - #424 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to provide a CSV delimiter for adding and updating CSV documents as in the specification
SDK requirements: meilisearch/integration-guides#251
All these methods taking
CSVhave changedChanges:
CsvDocumentsQuery{}AddDocumentsCsv(documents []byte, primaryKey ...string) (resp *TaskInfo, err error)->
AddDocumentsCsv(documents []byte, options *CsvDocumentsQuery) (resp *TaskInfo, err error)AddDocumentsCsvInBatches(documents []byte, batchSize int, primaryKey ...string) (resp []TaskInfo, err error)->
AddDocumentsCsvInBatches(documents []byte, batchSize int, options *CsvDocumentsQuery) (resp []TaskInfo, err error)UpdateDocumentsCsv(documents []byte, primaryKey ...string) (resp *TaskInfo, err error)->
UpdateDocumentsCsv(documents []byte, options *CsvDocumentsQuery) (resp *TaskInfo, err error)UpdateDocumentsCsvInBatches(documents []byte, batchSize int, primaryKey ...string) (resp []TaskInfo, err error)->
UpdateDocumentsCsvInBatches(documents []byte, batchSize int, options *CsvDocumentsQuery) (resp []TaskInfo, err error)