Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat sort facets value by alphanumerical or count order #558

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Aug 15, 2024

Pull Request

Related issue

Fixes #469

What does this PR do?

  • Sort facets value by alphanumerical or count order

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (17cedba) to head (05e0174).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          11       11           
  Lines        1957     1957           
=======================================
  Hits         1698     1698           
  Misses        159      159           
  Partials      100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza added enhancement New feature or request breaking-change The related changes are breaking for the users and removed enhancement New feature or request labels Aug 15, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Ja7ad

Can you remove from this PR the things that are not related to facets improvement please? Like Makefile and the changes in the README

You can open another PR for them of course

@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Aug 15, 2024

@curquiza I fixed it.

@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Aug 17, 2024

@curquiza did you check?

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

bors merge

Copy link
Contributor

meili-bors bot commented Aug 20, 2024

@meili-bors meili-bors bot merged commit 310e6b9 into meilisearch:main Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Sort facets value by alphanumerical or count order
2 participants