-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat sort facets value by alphanumerical or count order #558
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 11 11
Lines 1957 1957
=======================================
Hits 1698 1698
Misses 159 159
Partials 100 100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Ja7ad
Can you remove from this PR the things that are not related to facets improvement please? Like Makefile and the changes in the README
You can open another PR for them of course
# Conflicts: # types_easyjson.go
@curquiza I fixed it. |
@curquiza did you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiice
bors merge
Pull Request
Related issue
Fixes #469
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!