Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetOrCreateIndex method #22

Closed
2 tasks
eskombro opened this issue Sep 22, 2020 · 6 comments · Fixed by #45
Closed
2 tasks

Add GetOrCreateIndex method #22

eskombro opened this issue Sep 22, 2020 · 6 comments · Fixed by #45
Assignees
@arjunrc143

Comments

@eskombro
Copy link
Member

eskombro commented Sep 22, 2020 •
edited
Loading

Gets the index instance or creates a new one if it does not exist

  • Implement getOrCreate method
  • Add tests

Follows this discussion
@arjunrc143
Copy link
Contributor

@eskombro Can I give a try on this?

@eskombro
Copy link
Member Author

eskombro commented Oct 26, 2020 •
edited
Loading

Hello @arjunrc143

I am very sorry for my late answer!
Indeed, it would be great!

Do not hesitate if you need help with anything

@arjunrc143
Copy link
Contributor

Hello @arjunrc143

I am very sorry for my late answer!
Indeed, it would be great!

Do not hesitate if you need help with anything

Does the master contains breaking changes?

@arjunrc143
Copy link
Contributor

#45

I have added a PR. Please check. I havent updated the integration tests, but I would like to. Can you please help me in setting up environment for integration tests. @eskombro

@eskombro
Copy link
Member Author

eskombro commented Oct 27, 2020 •
edited
Loading

Does the master contains breaking changes?

This SDK is still in WIP, so breaking changes are more than common every day. When we do the release, it will follow the semver system to announce breaking changes! But for now, there is no point in trying to be stable :)

@eskombro
Copy link
Member Author

#45

I have added a PR. Please check. I havent updated the integration tests, but I would like to. Can you please help me in setting up environment for integration tests. @eskombro

Are you in our Slack? Do not hesitate to contact me there (I'm Samuel) and I will be happy to help you!

We will add some guides soon to this repo, but it is still a bit early to add guides, as everything changes all the time

arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Oct 27, 2020
meilisearch#22 | Get index only if the exception has index_already_ex…
099dad0 
…ists message in exception
@arjunrc143 arjunrc143 mentioned this issue Oct 27, 2020
Merged
@eskombro eskombro linked a pull request Oct 27, 2020 that will close this issue
#22 | Add getOrCreateIndex functionality #45
Merged
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Oct 28, 2020
meilisearch#22 | Correct the package of TestData and AbstractIT
90de15b
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Oct 28, 2020
meilisearch#22 | Add integration tests for getOrCreateIndex functiona…
211471f 
…lity
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Oct 28, 2020
Revert "meilisearch#22 | Correct the package of TestData and AbstractIT"
fc50754 
This reverts commit 90de15b.
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Nov 4, 2020
meilisearch#22 | Get index only if the exception has index_already_ex…
faa21dd 
…ists message in exception
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Nov 4, 2020
meilisearch#22 | Correct the package of TestData and AbstractIT
e01af91
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Nov 4, 2020
meilisearch#22 | Add integration tests for getOrCreateIndex functiona…
7459368 
…lity
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Nov 4, 2020
Revert "meilisearch#22 | Correct the package of TestData and AbstractIT"
8e52501 
This reverts commit 90de15b.
arjunrc143 pushed a commit to arjunrc143/meilisearch-java that referenced this issue Nov 4, 2020
meilisearch#22 | Add getOrCreateIndex method without primary key
1a71145
eskombro pushed a commit that referenced this issue Nov 5, 2020
@arjunrc143
#22 | Add getOrCreateIndex functionality (#45)
f05cb9c 
* Add getOrCreateIndex functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunrc143 arjunrc143

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#22 | Add getOrCreateIndex functionality arjunrc143/meilisearch-java
2 participants
@arjunrc143 @eskombro