Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of naming methods related to Ranking Rules #525

Closed
alallema opened this issue Jan 10, 2023 · 1 comment · Fixed by #539
Closed

Correction of naming methods related to Ranking Rules #525

alallema opened this issue Jan 10, 2023 · 1 comment · Fixed by #539
Labels
good first issue Good for newcomers maintenance Anything related to maintenance (CI, tests, refactoring...)

Comments

@alallema
Copy link
Contributor

Description
All three methods related to Ranking Rules Setting have a typo and missing the s to rules

To do

  • Rename getRankingRuleSettings to getRankingRulesSettings
  • Rename udpateRankingRuleSettings to udpateRankingRulesSettings
  • Rename resetRankingRuleSettings to resetRankingRulesSettings
  • Update code-sample with the new names
  • Update tests with the new names
@alallema alallema added good first issue Good for newcomers maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jan 10, 2023
@ghousek1 ghousek1 mentioned this issue Feb 11, 2023
Merged
3 tasks
@ghousek1
Copy link
Contributor

hi @alallema renamed the methods in source code along with test case names and variable names in test cases . please let me know if any change is required

@bors bors bot closed this as completed in 61ae656 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correction of naming methods related to Ranking Rules ghousek1/meilisearch-java
2 participants
@alallema @ghousek1