Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of naming methods related to Ranking Rules #539

Conversation

ghousek1
Copy link
Contributor

@ghousek1 ghousek1 commented Feb 11, 2023

Pull Request

Related issue

Fixes #525

What does this PR do?

  • Correction of naming methods related to Ranking Rules

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghousek1 for this PR and for contributing to Meilisearch ❤️
LGTM! 🎉

@alallema alallema added the breaking-change The related changes are breaking for the users label Feb 13, 2023
@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 13, 2023

Build succeeded:

  • integration-and-unit-tests
  • linter

@bors bors bot merged commit 61ae656 into meilisearch:main Feb 13, 2023
bors bot added a commit that referenced this pull request Feb 14, 2023
542: Update version for the next release (v0.10.0) r=alallema a=alallema

Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes.

## ⚠️ Breaking changes

This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`.
* The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486
* Correction of naming methods related to Ranking Rules (#539) `@ghousek1`

## 🚀 Enhancements

* Ensure support to the new search query parameter `MatchingStrategy` (#434) `@alallema`
* Ensure support to keys with wildcarded actions.
  - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#434) `@alallema` 

Thanks again to `@alallema` and `@ghousek1` ! 🎉

Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correction of naming methods related to Ranking Rules
2 participants