Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.4] Support user-dictionary loading #660

Closed
7 tasks
curquiza opened this issue Sep 27, 2023 · 0 comments · Fixed by #689
Closed
7 tasks

[v1.4] Support user-dictionary loading #660

curquiza opened this issue Sep 27, 2023 · 0 comments · Fixed by #689
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Following this central issue

  • Add a new setting: dictionary with get, update, and reset methods associated.
    Here are the JS equivalents in meilisearch-js you should create for this repository:
client.index('indexName').getDictionary(); // calls GET /indexes/:uid/settings/dictionary
client.index('indexName').updateDictionary(['|', '/', '&sep']);  // calls PUT /indexes/:uid/settings/dictionary
client.index('indexName').resetDictionary(); // calls DELETE /indexes/:uid/settings/dictionary
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2023
@mesutgk15 mesutgk15 mentioned this issue Nov 24, 2023
Merged
3 tasks
meili-bors bot added a commit that referenced this issue Dec 11, 2023
@meili-bors @mesutgk15 @dependabot
Merge #689 #695
15a56a2 
689: Support user-dictionary loading #660 r=brunoocasali a=mesutgk15

# Pull Request

## Related issue
Fixes #660

## What does this PR do?
- Add a new setting as dictionary and get, update, reset methods for this setting 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


695: Bump org.junit:junit-bom from 5.10.0 to 5.10.1 r=brunoocasali a=dependabot[bot]

Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.0 to 5.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/junit-team/junit5/releases">org.junit:junit-bom's releases</a>.</em></p>
<blockquote>
<p>JUnit 5.10.1 = Platform 1.10.1 + Jupiter 5.10.1 + Vintage 5.10.1</p>
<p>See <a href="http://junit.org/junit5/docs/5.10.1/release-notes/">Release Notes</a>.</p>
<p><strong>Full Changelog</strong>: <a href="https://github.com/junit-team/junit5/compare/r5.10.0...r5.10.1">https://github.com/junit-team/junit5/compare/r5.10.0...r5.10.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/junit-team/junit5/commit/e5f50d8720741623915979ac154b65bcbcd6a577"><code>e5f50d8</code></a> Release 5.10.1</li>
<li><a href="https://github.com/junit-team/junit5/commit/ac86d18e9b15dbebe046e82743ac7f9534a17582"><code>ac86d18</code></a> Fix typo in AfterAll documentation</li>
<li><a href="https://github.com/junit-team/junit5/commit/388c5beaf42944961ab5b455c900d958a6e15588"><code>388c5be</code></a> Harmonize application of method and field filters in search algorithms</li>
<li><a href="https://github.com/junit-team/junit5/commit/f82dd1e716f8717e012152b1d1d5cc0da10d33cd"><code>f82dd1e</code></a> Apply field predicate before searching type hierarchy</li>
<li><a href="https://github.com/junit-team/junit5/commit/1d1eb8571552bbf28e578241965010de6c8ee779"><code>1d1eb85</code></a> Polishing</li>
<li><a href="https://github.com/junit-team/junit5/commit/5ce280eff69b43759a3cb0c176207abe0a41b579"><code>5ce280e</code></a> Update picocli to 4.7.5 and enable help width computation</li>
<li><a href="https://github.com/junit-team/junit5/commit/fea05c3aa80de76686f326b5ce26ddf7f153ff5a"><code>fea05c3</code></a> Fix ConsoleLauncherTests and StandaloneTests</li>
<li><a href="https://github.com/junit-team/junit5/commit/c5567354c2556e772f8a0035ef7647161011d1c0"><code>c556735</code></a> Use same expected files for all JDK versions</li>
<li><a href="https://github.com/junit-team/junit5/commit/808493ab09b30970b506a48fda3d616ac1ba4fff"><code>808493a</code></a> Run StandaloneTests for Java 8 under Java 8</li>
<li><a href="https://github.com/junit-team/junit5/commit/9ec57661c78c3889db004ab6a89416e56a2fb2e0"><code>9ec5766</code></a> Unify messages about exit codes in StandaloneTests</li>
<li>Additional commits viewable in <a href="https://github.com/junit-team/junit5/compare/r5.10.0...r5.10.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.junit:junit-bom&package-manager=gradle&previous-version=5.10.0&new-version=5.10.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: mesut <guzelkaralarm@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
meili-bors bot added a commit that referenced this issue Dec 11, 2023
@meili-bors @mesutgk15
Merge #689
85e82d1 
689: Support user-dictionary loading #660 r=brunoocasali a=mesutgk15

# Pull Request

## Related issue
Fixes #660

## What does this PR do?
- Add a new setting as dictionary and get, update, reset methods for this setting 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: mesut <guzelkaralarm@gmail.com>
@meili-bors meili-bors bot closed this as completed in 63053d8 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support user-dictionary loading #660 mesutgk15/meilisearch-java
1 participant
@curquiza