Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Key type updatedAt typo. #1524

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix Key type updatedAt typo. #1524

merged 1 commit into from
Jun 26, 2023

Conversation

riccox
Copy link
Contributor

@riccox riccox commented Jun 21, 2023

Pull Request

Related issue

No

What does this PR do?

  • Fix typos for Key type param, "updateAt" should be "updatedAt".

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch <3

@bidoubiwa bidoubiwa self-requested a review June 21, 2023 16:08
@bidoubiwa
Copy link
Contributor

bidoubiwa commented Jun 21, 2023 •
edited
Loading

The tests need to be updated with the fix, could you do it?

@riccox riccox force-pushed the patch-1 branch 2 times, most recently from c7394f3 to 700034e Compare June 22, 2023 01:41
@riccox
Fix Key type param typos.
c66a42c 
Key type param "updateAt" should be "updatedAt"
@riccox
Copy link
Contributor Author

riccox commented Jun 22, 2023

The tests need to be updated with the fix, could you do it?

Sure, I have done it!

bidoubiwa
bidoubiwa approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bidoubiwa
Copy link
Contributor

thanks a lot :)

@bidoubiwa bidoubiwa added the bug Something isn't working label Jun 26, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 26, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 413d555 into meilisearch:main Jun 26, 2023
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@riccox riccox deleted the patch-1 branch June 26, 2023 08:42
@bidoubiwa bidoubiwa changed the title Fix Key type param typos. Fix Key type updatedAt typo. Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riccox @bidoubiwa @meili-bot