Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add dumpCreation in type TaskTypes #1568

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: add dumpCreation in type TaskTypes #1568

merged 1 commit into from
Aug 18, 2023

Conversation

nicolasvienot
Copy link
Member

@nicolasvienot nicolasvienot commented Aug 17, 2023 •
edited
Loading

Pull Request

Related issue

Fixes #1567

Meilisearch tasks type can be dumpCreation but it's missing in the type TaskTypes in meilisearch-js.
See tasks documentation here: https://www.meilisearch.com/docs/reference/api/tasks#type

What does this PR do?

  • Add dumpCreation in type TaskTypes
  • Reorder in alphabetical order

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@brunoocasali
Copy link
Member

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 18, 2023

Build succeeded:

@nicolasvienot nicolasvienot merged commit d99a264 into main Aug 18, 2023
5 checks passed
@nicolasvienot nicolasvienot deleted the add-task-type-dump-creation branch August 18, 2023 00:54
@bidoubiwa bidoubiwa added the bug Something isn't working label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@atoulmet atoulmet Awaiting requested review from atoulmet

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing type dumpCreation in type TaskTypes
3 participants
@nicolasvienot @brunoocasali @bidoubiwa