Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filterable attribute example in README.md #1584

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix filterable attribute example in README.md #1584

merged 1 commit into from
Sep 20, 2023

Conversation

curquiza
Copy link
Member

Fixes #1583

@curquiza curquiza added documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs labels Sep 20, 2023
@curquiza curquiza mentioned this pull request Sep 20, 2023
Closed
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cfd27e6) 97.25% compared to head (240db13) 97.25%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          22       22           
  Lines         765      765           
  Branches      108      108           
=======================================
  Hits          744      744           
  Misses         20       20           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mdubus
mdubus approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🦕

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 20, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit d5c2bde into main Sep 20, 2023
8 checks passed
@meili-bors meili-bors bot deleted the curquiza-patch-2 branch September 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubus mdubus mdubus approved these changes

@bidoubiwa bidoubiwa Awaiting requested review from bidoubiwa

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: index.updateAttributesForFaceting is not a function
2 participants
@curquiza @mdubus