-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve eslint
config, other minor changes
#1795
Fix and improve eslint
config, other minor changes
#1795
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 18 18
Lines 1546 1546
Branches 326 326
=======================================
Hits 1514 1514
Misses 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @flevi29, thank you for this PR.
This is a welcome simplification of the eslint configuration.
It would have been simpler to review if the typescript part was made in a separate PR.
I left a small comment, but the rest seems good to me. Happy to merge after next week's releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Pull Request
What does this PR do?
eslint
config was set up in a confusing way, now it's simplified and works as it shouldtypescript
didn't check test files, now it doesPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!