Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve eslint config, other minor changes #1795

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Dec 6, 2024

Pull Request

What does this PR do?

  • eslint config was set up in a confusing way, now it's simplified and works as it should
  • typescript didn't check test files, now it does

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added bug Something isn't working maintenance Issue about maintenance (CI, tests, refacto...) labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (d8ef010) to head (8353590).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          18       18           
  Lines        1546     1546           
  Branches      326      326           
=======================================
  Hits         1514     1514           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Strift Strift self-requested a review December 16, 2024 10:58
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flevi29, thank you for this PR.

This is a welcome simplification of the eslint configuration.
It would have been simpler to review if the typescript part was made in a separate PR.

I left a small comment, but the rest seems good to me. Happy to merge after next week's releases.

tests/search.test.ts Show resolved Hide resolved
@flevi29 flevi29 removed the bug Something isn't working label Dec 27, 2024
@flevi29 flevi29 requested a review from Strift December 27, 2024 08:40
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Dec 27, 2024

@meili-bors meili-bors bot merged commit 47fcb09 into meilisearch:main Dec 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants