Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

Fix SearchResult return value in custom search callable #88

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Fix SearchResult return value in custom search callable #88

merged 1 commit into from
Feb 1, 2021

Conversation

mmachatschek
Copy link
Collaborator

@mmachatschek mmachatschek commented Jan 31, 2021 •
edited
Loading

Attempt to fix issues from #86 and the update of the release https://github.com/meilisearch/meilisearch-php/releases/tag/v0.16.0

The ->search() method on the Indexes::class is able to return either an array or an SearchResult::class.

Fixes #87

@mmachatschek
Copy link
Collaborator Author

@shokme we can safely use the SearchResult::class as you already bumped the meilisearch-php package to ^0.16 in ec84f50#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

shokme
shokme approved these changes Jan 31, 2021
View reviewed changes
Copy link
Collaborator

@shokme shokme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me !
Thank you very much for your contribution

curquiza
curquiza approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mmachatschek! Thanks for this addition 👍!!

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 1, 2021

Build succeeded:

@bors bors bot merged commit 1d5ad09 into meilisearch:master Feb 1, 2021
@mmachatschek mmachatschek deleted the fix_custom_search branch February 1, 2021 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@curquiza curquiza curquiza approved these changes

@shokme shokme shokme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use object of type MeiliSearch\Search\SearchResult as array
3 participants
@mmachatschek @shokme @curquiza