Make the usage of the module typing consistent

[alallema]

In some parts of the SDK, the typing module is used but not everywhere so that in some places the dict type is used and in others the Dict type.
It would be nice to make the whole thing coherent and make it easier to use the module everywhere.

[sanders41]

I think you are referring to Dict in this file. The reason it uses Dict instead of dict is Pydantic won't work with all the supported python versions using dict (can't use __future__ annotations).

You could go back to using from typing import Dict everywhere. Technically Union in this file would fall under this also, so str | None (or any union type like this) would become Union[str, None]. In addition any new types added to a Pydantic model that require import from typing, List, Tuple, etc. the same thing would need to be done.

[alallema]

Hi @sanders41,

I think you are referring to Dict in this file.

Yes totally

You could go back to using from typing import Dict everywhere. Technically Union in this file would fall under this also, so str | None (or any union type like this) would become Union[str, None].

Yes I have read some debates about what was best to use:
Union[str, None]
Optional[str]
str | None
But I don't have an opinion on the matter I just wish that all the code was written in a homogeneous way and compatible with all versions.

Thanks for your advice ❤️