Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change typing using the typing lib #625

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Change typing using the typing lib #625

merged 1 commit into from
Dec 19, 2022

Conversation

pbrochar
Copy link

Pull Request

Related issue

Fixes #611

What does this PR do?

  • Change typing for more coherence in the definition of functions

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

alallema
alallema approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pbrochar for this PR and for contributing to Meilisearch ❤️
LGTM! 🎉

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 19, 2022

Build succeeded:

@bors bors bot merged commit 8307786 into meilisearch:main Dec 19, 2022
@alallema alallema added the breaking-change The related changes are breaking for the users label Feb 6, 2023
@alallema alallema mentioned this pull request Feb 6, 2023
Merged
bors bot added a commit that referenced this pull request Feb 6, 2023
@bors @alallema
Merge #678
bace22a 
678: Update version for the next release (v0.24.0) r=alallema a=alallema

This version makes this package compatible with Meilisearch v1.0.0 🎉
Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes(#635).

## ⚠️ Breaking changes

* Make the usage of the module typing consistent (#625) `@pbrochar`
* Put all dates to `datetime` type for consistency. Class impacted: `Task` and `TasInfo` (#661) `@Azanul`
* Change `details` fields in `Task` class `Dict[str, Any]` -> `Union[Dict[str, Any], None]` (#664) `@Azanul`

## 🚀 Enhancements

* Added `update_documents_csv(str_documents: str, primary_key: Optional[str] = None) -> TaskInfo` (#654) `@sajdakabir`

## 🐛 Bug Fixes

* Include py.typed in package build (#637) `@sanders41`

Thanks again to `@Azanul,` `@alallema,` `@pbrochar,` `@sajdakabir,` `@sanders41!` 🎉



Co-authored-by: alallema <amelie@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the usage of the module typing consistent
2 participants
@pbrochar @alallema