Restructure code #176
Merged
Restructure code #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
added
the
breaking-change
curquiza
force-pushed
the
restructure-code
branch
from
e5ed004 to
aef9d10
Compare
bidoubiwa
previously approved these changes
Nov 16, 2020
eskombro
requested changes
Nov 17, 2020
curquiza
force-pushed
the
restructure-code
branch
2 times, most recently
from
98ebb38 to
5414d3c
Compare
curquiza
force-pushed
the
implicit-index-creation-v2
branch
from
c37ee08 to
ed86de1
Compare
curquiza
force-pushed
the
restructure-code
branch
from
5414d3c to
2b61652
Compare
curquiza
force-pushed
the
restructure-code
branch
from
2b61652 to
8f57cf0
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
Index.create(...)a@classmethodinstead of a@staticmethod. Why? Put the logic related to an index in theIndexclass instead of theClientclass.See the difference between static and class methods in Python: https://stackabuse.com/pythons-classmethod-and-staticmethod-explained/.
Index.get_indexes(). Since it's not related to only one index, this method should not be present in theIndexclass.update()method returns anIndexobject instead of adictbecause it's more convenient to manipulate object instead of dict. This is consitent withclient.index('movies').fetch_info()andclient.create_index('movies)andclient.index('movies')Changes:
assert isinstance(response, Index)