Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return task instances from task methods instead of dicts #750

Merged
merged 2 commits into from
May 10, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Relates to #747

What does this PR do?

  • Returns an appropriate task class instance from task methods instead of dicts

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the breaking-change The related changes are breaking for the users label May 10, 2023
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41, so efficient 🚀
This is where I realize that I have changed the index methods but the class methods ... I put some suggestions to modify some definitions

meilisearch/client.py Outdated Show resolved Hide resolved
meilisearch/client.py Outdated Show resolved Hide resolved
meilisearch/client.py Show resolved Hide resolved
meilisearch/task.py Outdated Show resolved Hide resolved
meilisearch/task.py Show resolved Hide resolved
meilisearch/task.py Outdated Show resolved Hide resolved
meilisearch/task.py Outdated Show resolved Hide resolved
@sanders41
Copy link
Collaborator Author

Updates done.

Thanks for the updates, I didn't like my descriptions, these are better 😃

@alallema
Copy link
Contributor

Thanks for the updates, I didn't like my descriptions, these are better 😃

I stole it from the one above 😄

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@alallema
Copy link
Contributor

bors merge

@sanders41
Copy link
Collaborator Author

I think the 3.10 test failed, and my subsequent restart acting weird is a GitHub Issue.

Actions: partial outage

I'm guessing it will resolve itself.

@meili-bors
Copy link
Contributor

meili-bors bot commented May 10, 2023

@meili-bors meili-bors bot merged commit baa62f7 into main May 10, 2023
@meili-bors meili-bors bot deleted the task-return branch May 10, 2023 13:22
@alallema
Copy link
Contributor

I think the 3.10 test failed, and my subsequent restart acting weird is a GitHub Issue.

Yes, I saw that too, I have the same kind of problem on other repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants