-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return task instances from task methods instead of dicts #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sanders41, so efficient 🚀
This is where I realize that I have changed the index methods but the class methods ... I put some suggestions to modify some definitions
Updates done. Thanks for the updates, I didn't like my descriptions, these are better 😃 |
I stole it from the one above 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
bors merge |
I think the 3.10 test failed, and my subsequent restart acting weird is a GitHub Issue. Actions: partial outage I'm guessing it will resolve itself. |
Yes, I saw that too, I have the same kind of problem on other repo. |
Pull Request
Related issue
Relates to #747
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!