Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support #788

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Drop Python 3.7 support #788

merged 1 commit into from
Jun 27, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Tomorrow, 2023-06-27, Python 3.7 is at end of life so this PR removes it from the supported versions.

Related issue

Fixes #<issue_number>

What does this PR do?

  • Removes support for Python 3.7

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41
Copy link
Collaborator Author

The waiting test is the required python 3.7 test. That one just needs to be removed from the required tests in the github branch protection rules.

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @sanders41 🚀
LGTM!
I remove the test from the github-action, so everything is ready for tomorrow's EOF of Python 3.7

@alallema
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 27, 2023

@meili-bors meili-bors bot merged commit 92bc8c3 into main Jun 27, 2023
@meili-bors meili-bors bot deleted the py37 branch June 27, 2023 18:37
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@alallema alallema added the enhancement New feature or request label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants