Fix potential json_encoding date error and truncation in pydantic < 2 #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Good catch @sanders41 🚀
I've never encountered this problem either, but I'm sure we never test dates with Z either.
LGTM! 🎉
meili-bors bot
added a commit
that referenced
this pull request
Jul 31, 2023
815: Update version for the next release (v0.28.2) r=sanders41 a=meili-bot This version introduces features released on Meilisearch v1.3.0 🎉 Check out the changelog of [Meilisearch v1.3.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.3.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ## 🚀 Enhancements *⚠️ **EXPERIMENTAL**: Adds docstring and tests for vector search (#805) `@sanders41`⚠️ The EXPERIMENTAL features are not covered by semver. To explicitly opt-in, check this [guide](https://www.meilisearch.com/docs/reference/api/experimental-features). ## 🐛 Bug Fixes * Fix potential json_encoding date error and truncation in pydantic < 2 (#807) `@sanders41` ## 💅 Misc * Migrate docs hosting to Meilisearch subdomain (#810) `@Strift` * Update documentation deployment workflow (#811) `@Strift` Thanks again to `@Strift,` `@alallema,` and `@sanders41!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
I came across some instances that can cause the current
json_encoderfor dates to either error or return truncated values in Pydantic < 2. The encoder this is updating is the same one we have been using all along and no one reported issues so it seems as though I just stumbled upon this by chance.Related issue
Fixes #<issue_number>
What does this PR do?
+00:00Zdates to prevent truncationPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!