Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total to TasksResult #833

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

arturgoms
Copy link
Contributor

Pull Request

Related issue

Fixes #831

What does this PR do?

  • add total to the TasksResult class

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (a26fc60) 92.12% compared to head (972d258) 92.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   92.12%   92.13%   +0.01%     
==========================================
  Files          13       13              
  Lines         775      776       +1     
==========================================
+ Hits          714      715       +1     
  Misses         61       61              
Files Changed Coverage Δ
meilisearch/models/task.py 68.83% <100.00%> (+0.41%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @arturgoms!

@sanders41
Copy link
Collaborator

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 8, 2023

@arturgoms arturgoms closed this Aug 8, 2023
@meili-bors meili-bors bot merged commit 9fa3a75 into meilisearch:main Aug 8, 2023
@sanders41 sanders41 added the enhancement New feature or request label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Total Tasks in task route
3 participants