implemented createSnapshot method and created entry with create_snaps… #885
Conversation
|
Not quite sure where I can update the code-samples, can some one guide me there ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 748 752 +4
=========================================
+ Hits 748 752 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
For the documentation the .code-samples.meilisearch.yaml file does that so you have already done it.
We also need to add a test for the snapshot creation, you can model it off the dump creation tests. Just note that your test will probably fail until #887 is merged.
Co-authored-by: Paul Sanders <psanders1@gmail.com>
There was a problem hiding this comment.
I expected the integration tests to fail while we wait on the other PR to merge. The test looks good so I expect it will pass after the other PR is brought in here.
For the failing black and pylint tests running black meilisearch tests should fix both of these.
|
I'll wait to merge this until we have all the tests passing, but I'll be surprised if we need any more changes here. Everything looks good to me, we just need the other bug fix to merge. |
Thank you of such a great collaboration! I will wait for the updates |
|
Hello everyone Thank you for your work here ❤️ |
|
bors merge |
|
Build succeeded:
|
Pull Request
Related issue
Fixes #884
What does this PR do?
This pr Implements the new createSnapshot method in the meilisearch\client.py, also creates a new entry with the key "create_snapshot_1:" in the .code-samples.meilisearch.yml
PR checklist
Please check if your PR fulfills the following requirements: