Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new MeiliSearch::Error from which other errors inherit #492

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Add new MeiliSearch::Error from which other errors inherit #492

merged 4 commits into from
Oct 9, 2023

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Oct 4, 2023

Pull Request

Related issue

Fixes #467

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (01b1c89) 99.60% compared to head (573fe33) 99.60%.

❗ Current head 573fe33 differs from pull request most recent head 6b5e173. Consider uploading reports for the commit 6b5e173 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           9        9           
  Lines         508      509    +1     
=======================================
+ Hits          506      507    +1     
  Misses          2        2
Files Coverage Δ
lib/meilisearch/error.rb 97.36% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ellnix ellnix force-pushed the extend-all-errors-from-base-error branch from 4c7ead8 to bea47de Compare October 6, 2023 15:28
brunoocasali
brunoocasali previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@ellnix ellnix force-pushed the extend-all-errors-from-base-error branch from bea47de to 6b5e173 Compare October 7, 2023 12:45
@ellnix ellnix force-pushed the extend-all-errors-from-base-error branch from 6b5e173 to dc3f9bd Compare October 9, 2023 12:30
brunoocasali
brunoocasali approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 9, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 8680ee7 into meilisearch:main Oct 9, 2023
@brunoocasali brunoocasali added the enhancement New feature or request label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure the error handling are following the best practice
2 participants
@ellnix @brunoocasali