Remove jsonindex #278
Merged
Remove jsonindex #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
requested changes
Apr 27, 2022
abhizer
force-pushed
the
remove_jsonindex
branch
from
1d12c29 to
c7d2715
Compare
irevoire
previously approved these changes
May 2, 2022
There was a problem hiding this comment.
@bidoubiwa or @brunoocasali, this PR looks good to me, I think we can merge when one of you have the time to review it 😁
brunoocasali
reviewed
May 3, 2022
There was a problem hiding this comment.
Hi @abhizer thanks a lot for your contribution, it is really appreciated ❤️
I left some comments in your PR, just to make sure I understood everything!
Commit Suggestion: Avoid creating a new Index in get_raw_index Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Commit Suggestion: Make test_fetch_info more readable Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
brunoocasali
approved these changes
May 4, 2022
irevoire
approved these changes
May 5, 2022
|
yes that's super breaking |
bidoubiwa
added
breaking-change
|
Should the code-samples be updated here? |
|
Went through the code samples, didn't notice anything that'd need to be changed. |
bors bot
added a commit
that referenced
this pull request
May 5, 2022
278: Remove jsonindex r=bidoubiwa a=abhizer # Pull Request ## What does this PR do? Fixes #187 #187 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? ## Todo List: - [x] Add fields updated_at, created_at and primary_key to Index - [x] Make get_raw_index return the raw Value that's returned by Meilisearch - [x] Update fetch_info to update Index instead of returning JsonIndex - [x] Remove JsonIndex and update everything (like get_raw_index) that relies on it to use Index - [x] Tests *P.S.: I think this requires a thorough review, as a lot of things have been changed.* Thank you so much for contributing to Meilisearch! Co-authored-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
|
Build failed: |
|
bors try |
tryBuild succeeded: |
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
May 9, 2022
287: Update version for the next release (v0.17.0) r=curquiza a=brunoocasali This version makes this package compatible with Meilisearch v0.27.0 🎉 Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes. ##⚠️ Breaking changes * Remove jsonindex (#278) `@abhizer` ## 🚀 Enhancements * Add cli-app example to meilisearch-rust (#279) `@salugi` * Ensure nested field support (#273) `@bidoubiwa` * Add new search parameters `highlightPreTag`, `highlightPostTag` and `cropMarker` (#274) `@bidoubiwa` * Add User-Agent header to have analytics in every HTTP request (#254) `@brunoocasali` Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection) Also, of course, every analytics data we collect are **ANONYMOUS** [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html). Thanks again to `@abhizer,` `@bidoubiwa,` `@irevoire,` `@salugi` and a1! 🎉 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #187
#187
PR checklist
Please check if your PR fulfills the following requirements:
Todo List:
P.S.: I think this requires a thorough review, as a lot of things have been changed.
Thank you so much for contributing to Meilisearch!