-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement client for experimental-features API #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ❤️
I'll let @irevoire merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
509: Add total field to get-tasks route r=irevoire a=hmacr # Pull Request ## Related issue Fixes #504 ## What does this PR do? - Adds `total` field to `get-tasks` route ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 516: Implement client for experimental-features API r=irevoire a=hmacr # Pull Request ## Related issue Needed for #498 & #501, since these issues involve updating the experimental-feature as a pre-requisite ## What does this PR do? - Introduces the experimental-features client in the SDK - Implements the `get` and `patch` endpoint. - Adds code-samples and tests. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: hmacr <hmac.devo@gmail.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
509: Add total field to get-tasks route r=curquiza a=hmacr # Pull Request ## Related issue Fixes #504 ## What does this PR do? - Adds `total` field to `get-tasks` route ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 516: Implement client for experimental-features API r=curquiza a=hmacr # Pull Request ## Related issue Needed for #498 & #501, since these issues involve updating the experimental-feature as a pre-requisite ## What does this PR do? - Introduces the experimental-features client in the SDK - Implements the `get` and `patch` endpoint. - Adds code-samples and tests. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: hmacr <hmac.devo@gmail.com> Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors merge |
Build succeeded:
|
519: Update version for v0.24.2 r=curquiza a=curquiza ## 🚀 Enhancements * Re-export public structures for better import path (#493) `@adriantombu` * Added function for sending NDJSON documents (#494) `@carlosb1` * Add missing startedAt field in EnqueuedTask (#485) `@sebastiantoh` * #499 (attributesToSearchOn) (#510) `@brendon-shf` * Add total field to get-tasks route (#509) `@hmacr` * Implement client for experimental-features API (#516) `@hmacr` Co-authored-by: curquiza <clementine@meilisearch.com>
Pull Request
Related issue
Needed for #498 & #501, since these issues involve updating the experimental-feature as a pre-requisite
What does this PR do?
get
andpatch
endpoint.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!