Add typo-tolerance APIs #411
Conversation
|
Flagging the same kind of error here as other PR - I think CI itself might need an update as passing locally with up to date version. I'll take a look into scripts and verify. |
Sherlouk
force-pushed
the
typo-tolerance
branch
from
5db5857 to
d46796a
Compare
|
As with the other PR, this was entirely my mistake. I've patched the tests, and ran all locally to verify behaviour. I've done an extra force commit above as CI failed to download the MeiliSearch binary after 10s - this was nothing to do with my work. The force commit has prompted CI to try again, and has seemingly made it further this time. |
|
I would recommend waiting for #417 to be merged, then I'll rebase this PR on top of that. With the improvements made there it'll reduce the size of this. |
|
@Sherlouk can you rebase please? 😇 |
Sherlouk
force-pushed
the
typo-tolerance
branch
from
d46796a to
a5cacc9
Compare
411: Add typo-tolerance APIs r=curquiza a=Sherlouk # Pull Request ## Related issue Fixes #282 ## What does this PR do? - Adds support for reading, updating, and resetting typo-tolerance preferences ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: James Sherlock <15193942+Sherlouk@users.noreply.github.com>
Sherlouk
force-pushed
the
typo-tolerance
branch
from
a5cacc9 to
8c6620f
Compare
|
Canceled. |
|
Huge apologies, I did an empty commit in order to fix the failed build (which wasn't due to my code!). |
|
No worries! |
|
bors merge |
Pull Request
Related issue
Fixes #282
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!