Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Container extension "meili_search" is not registered. #371

Merged

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Dec 3, 2024

Pull Request

Related issue

#370 (comment)

What does this PR do?

"meili_search" does not match the bundle name, "meilisearch," which causes some strange bugs, such as this issue.

I have completed a basic smoke test of PHP and YAML. I can confirm that the PHP configuration is now working with the Meilisearch bundle, while the old YAML configuration should function as it did before.

$ php bin/console meilisearch:import --update-settings
Importing for index App\Entity\Question
Indexed a batch of 70 / 70 App\Entity\Question entities into dev_questions index (70 indexed since start)
Setting "filterableAttributes" updated of "dev_questions".
Setting "sortableAttributes" updated of "dev_questions".
Done!

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

"meili_search" does not match the bundle name,
"meilisearch". It makes some weird bugs, like
this issue.
@pan93412 pan93412 force-pushed the fix-unregistered-extension-issue branch from 0f3d767 to 5e19616 Compare December 3, 2024 11:19
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (acf34e4) to head (5e19616).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #371   +/-   ##
=========================================
  Coverage     88.73%   88.73%           
  Complexity        1        1           
=========================================
  Files            20       20           
  Lines           914      914           
=========================================
  Hits            811      811           
  Misses          103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas
Copy link
Collaborator

norkunas commented Dec 3, 2024

But isn't this a BC break for others?

Edit: hmm, strange, in my app I am using meilisearch also

@pan93412
Copy link
Contributor Author

pan93412 commented Dec 3, 2024

But isn't this a BC break for others?

Edit: hmm, strange, in my app I am using meilisearch also

https://github.com/search?q=path%3Aconfig%2Fpackages%2Fmeilisearch.php&type=code

Besides, there was basically nobody like me who successfully applied ConfigBuilder for meilisearch. Since YAML functions as it did before, I believe there are no breaking changes, as the old method is never functional.

@norkunas
Copy link
Collaborator

norkunas commented Dec 3, 2024

bors merge

@meili-bors meili-bors bot merged commit 345bb2b into meilisearch:main Dec 3, 2024
20 checks passed
@pan93412 pan93412 deleted the fix-unregistered-extension-issue branch December 3, 2024 12:51
@norkunas
Copy link
Collaborator

norkunas commented Dec 3, 2024

Thank you @pan93412

@norkunas norkunas added the bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants