-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable importing from dumps v1 #3170
Conversation
c22ff6a
to
079ff3b
Compare
0420756
to
11614c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, it looks super good.
Could you add one test at the bottom of dump/src/reader/mod.rs
that imports our dump v1 through all our compat layers, please? 😁
2faa5b8
to
b727fe7
Compare
Oh sorry I didn't write a message to specify, but I did that. Also I detailed some of the quirks of the current implementation, format-wise, in #2985 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we're good to me!
bors merge
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
Stopped waiting for PR status (GitHub check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests. |
Pull Request
Related issue
Fixes #2985
What does this PR do?
User standpoint
After an import from a v1 dump, it is recommended that a user checks each index and its settings.
Implementation standpoint
00000000-0000-0000-0000-000000000001
, and so on... This should have no bearing on the final indexes because v6 is not using UUIDs, but this allows us to correctly identify which tasks belong to which index.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!