Introduce the error handler #225

Kerollmops · 2021-06-09T09:00:20Z

Fixes #109.

milli/src/error.rs

milli/src/search/criteria/exactness.rs

milli/src/search/mod.rs

milli/src/update/index_documents/transform.rs

ManyTheFish

bors merge

bors · 2021-06-16T10:14:53Z

Build succeeded:

ci (stable)

Kerollmops force-pushed the error-handling branch from 07b221c to 01ff24a Compare June 9, 2021 12:24

Kerollmops changed the title ~~Use the out of the compute_primary_key_pair function~~ Introduce the error handler Jun 9, 2021

Kerollmops force-pushed the error-handling branch 4 times, most recently from 5d36c0b to 297b0cf Compare June 10, 2021 13:56

Kerollmops added 10 commits June 14, 2021 16:48

Use the out of the compute_primary_key_pair function

ff9414a

Serializing a RoaringBitmap into a Vec cannot fail

93978ec

Prefer using an explicit merge function name

cfc7314

Remove the documents_merge method that must never be called

93a8633

Remove the docid_word_positions_merge method that must never be called

ab727e4

Move the obkv merging functions into the merge_function module

65b1d09

Remove a lot of serialization unreachable errors

d2b1ecc

Introduce a basic version of the InternalError struct

23fcf79

Introduce some way to construct an Error

44c353f

Implement the Display trait on the Error type

456541e

Kerollmops force-pushed the error-handling branch from a10138a to d9d6447 Compare June 14, 2021 14:58

Kerollmops added 2 commits June 14, 2021 16:58

Introduce more variants to the error module enums

ca78cb5

Use the Error enum everywhere in the project

312c2d1

Kerollmops force-pushed the error-handling branch from d9d6447 to 312c2d1 Compare June 14, 2021 14:58

Kerollmops added 3 commits June 14, 2021 18:06

Fix the http-ui crate

78fe425

Prefer using constant for the database names

28c004a

Rename the FieldIdMapMissingEntry from_db_name field into process

f0e804a

Kerollmops force-pushed the error-handling branch from c3657d8 to f0e804a Compare June 15, 2021 09:13

Replace the panicking expect by tracked Errors

a7d6930

Kerollmops marked this pull request as ready for review June 15, 2021 13:04

Kerollmops requested a review from ManyTheFish June 15, 2021 13:04

ManyTheFish suggested changes Jun 15, 2021

View reviewed changes

Kerollmops force-pushed the error-handling branch 2 times, most recently from 1c9680d to 49d7f7c Compare June 15, 2021 19:53

ManyTheFish suggested changes Jun 16, 2021

View reviewed changes

milli/src/update/index_documents/transform.rs Outdated Show resolved Hide resolved

Kerollmops and others added 6 commits June 16, 2021 11:03

Introduce the primary key to the Settings builder structure

713acc4

Add a new Error for when a user use a non-filtered attribute in a filter

4eda438

Rename DatabaseSizeReached into MaxDatabaseSizeReached

8cfe3e1

Rename FilterParsing into InvalidFilter

adf0c38

Fix small typos

7ac441e

Close write transaction in test

ce0315a

Kerollmops force-pushed the error-handling branch from 49d7f7c to ce0315a Compare June 16, 2021 09:03

ManyTheFish approved these changes Jun 16, 2021

View reviewed changes

Kerollmops added the DB breaking The related changes break the DB label Jun 16, 2021

bors bot merged commit 02e0271 into main Jun 16, 2021

bors bot deleted the error-handling branch June 16, 2021 10:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce the error handler #225

Introduce the error handler #225

Kerollmops commented Jun 9, 2021

ManyTheFish left a comment

bors bot commented Jun 16, 2021

Introduce the error handler #225

Introduce the error handler #225

Conversation

Kerollmops commented Jun 9, 2021

ManyTheFish left a comment

Choose a reason for hiding this comment

bors bot commented Jun 16, 2021