Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add benchmarks for indexing #287

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Add benchmarks for indexing #287

merged 1 commit into from
Jul 7, 2021

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Jul 7, 2021

closes #274
I don't really know how much time this will take on our bench machine. I'm afraid the wiki dataset will take a really long time to bench (it takes 1h30 on my computer).

If you are ok with it, I would like to merge this first PR since it introduces a first set of benchmarks and see how much time it takes in reality on our setup.

@irevoire irevoire marked this pull request as draft July 7, 2021 09:45
@irevoire irevoire force-pushed the bench/indexing branch 2 times, most recently from b37cfb5 to 029a2dd Compare July 7, 2021 11:07
@irevoire irevoire requested a review from Kerollmops July 7, 2021 11:11
@irevoire irevoire marked this pull request as ready for review July 7, 2021 11:11
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, merging!
bors merge

@@ -30,13 +30,13 @@ _[More about critcmp](https://github.com/BurntSushi/critcmp)._

### On your machine

To run all the benchmarks (~4h):
To run all the benchmarks (~5h):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To run all the benchmarks (~5h):
To run all the benchmarks (~8h):

@bors
Copy link
Contributor

bors bot commented Jul 7, 2021

@bors bors bot merged commit 16698f7 into main Jul 7, 2021
@bors bors bot deleted the bench/indexing branch July 7, 2021 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks for indexation
2 participants