This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Make sure that the relevancy is not impacted by other settings #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
changed the title
Add a test to check that we indeed impact the relevancy
Make sure that the relevancy is not impacted by other settings
Jul 22, 2021
Kerollmops
force-pushed
the
fix-settings-impacted-relevancy
branch
from
July 22, 2021 16:40
39e9a55
to
7aa6cc9
Compare
MarinPostma
force-pushed
the
fix-settings-impacted-relevancy
branch
from
July 26, 2021 17:15
10ec05e
to
28ac01b
Compare
Kerollmops
commented
Jul 27, 2021
Kerollmops
commented
Jul 27, 2021
Kerollmops
commented
Jul 27, 2021
MarinPostma
force-pushed
the
fix-settings-impacted-relevancy
branch
from
July 27, 2021 13:31
6deb0d7
to
bbbde34
Compare
Kerollmops
force-pushed
the
fix-settings-impacted-relevancy
branch
from
July 27, 2021 14:26
ba16049
to
0518da7
Compare
Kerollmops
force-pushed
the
fix-settings-impacted-relevancy
branch
from
July 27, 2021 14:34
0518da7
to
dc2b63a
Compare
MarinPostma
previously approved these changes
Jul 27, 2021
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2021
293: Make sure that the relevancy is not impacted by other settings r=Kerollmops a=Kerollmops Fix https://github.com/meilisearch/meilisearch/issues/1505. fix meilisearch/meilisearch#1529 Co-authored-by: Kerollmops <clement@meilisearch.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
MarinPostma
approved these changes
Jul 27, 2021
bors merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/meilisearch/meilisearch/issues/1505.
fix meilisearch/meilisearch#1529