Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Make sure that the relevancy is not impacted by other settings #293

Merged
merged 4 commits into from
Jul 27, 2021

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Jul 22, 2021

@Kerollmops Kerollmops changed the title Add a test to check that we indeed impact the relevancy Make sure that the relevancy is not impacted by other settings Jul 22, 2021
@Kerollmops Kerollmops force-pushed the fix-settings-impacted-relevancy branch from 39e9a55 to 7aa6cc9 Compare July 22, 2021 16:40
@MarinPostma MarinPostma force-pushed the fix-settings-impacted-relevancy branch from 10ec05e to 28ac01b Compare July 26, 2021 17:15
@MarinPostma MarinPostma force-pushed the fix-settings-impacted-relevancy branch from 6deb0d7 to bbbde34 Compare July 27, 2021 13:31
@Kerollmops Kerollmops force-pushed the fix-settings-impacted-relevancy branch from ba16049 to 0518da7 Compare July 27, 2021 14:26
@Kerollmops Kerollmops marked this pull request as ready for review July 27, 2021 14:33
@Kerollmops Kerollmops force-pushed the fix-settings-impacted-relevancy branch from 0518da7 to dc2b63a Compare July 27, 2021 14:34
@Kerollmops Kerollmops requested a review from MarinPostma July 27, 2021 14:35
MarinPostma
MarinPostma previously approved these changes Jul 27, 2021
@Kerollmops
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Jul 27, 2021
293: Make sure that the relevancy is not impacted by other settings r=Kerollmops a=Kerollmops

Fix https://github.com/meilisearch/meilisearch/issues/1505.

fix meilisearch/meilisearch#1529

Co-authored-by: Kerollmops <clement@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jul 27, 2021

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Kerollmops Kerollmops requested a review from MarinPostma July 27, 2021 15:16
@Kerollmops
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 27, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants