Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix: Count the number of char instead of counting bytes to assign the typo tolerance (fix Meilisearch 1714) #372

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Sep 28, 2021

The bug comes from the typo tolerance, to know how many typos are accepted we were counting bytes instead of characters in a word.
On Chinese Script characters, we were allowing 2 typos on 3 characters words.
We are now counting the number of char instead of counting bytes to assign the typo tolerance.

Related to Meilisearch#1714

@curquiza curquiza changed the title Fix meilisearch 1714 Count the number of char instead of counting bytes to assign the typo tolerance Sep 28, 2021
@ManyTheFish ManyTheFish changed the title Count the number of char instead of counting bytes to assign the typo tolerance Fix Meilisearch 1714 Sep 28, 2021
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, manyllmops!
bors merge

@bors
Copy link
Contributor

bors bot commented Sep 28, 2021

@bors bors bot merged commit b2a3325 into main Sep 28, 2021
@bors bors bot deleted the fix-meilisearch-1714 branch September 28, 2021 12:21
@curquiza curquiza changed the title Fix Meilisearch 1714 FIx: Count the number of char instead of counting bytes to assign the typo tolerance (fix Meilisearch 1714) Sep 29, 2021
@curquiza curquiza changed the title FIx: Count the number of char instead of counting bytes to assign the typo tolerance (fix Meilisearch 1714) Fix: Count the number of char instead of counting bytes to assign the typo tolerance (fix Meilisearch 1714) Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants