Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

deny warnings in CI #507

Merged
merged 1 commit into from
Apr 28, 2022
Merged

deny warnings in CI #507

merged 1 commit into from
Apr 28, 2022

Conversation

MarinPostma
Copy link
Contributor

@MarinPostma MarinPostma commented Apr 21, 2022 •
edited
Loading

Add RUSTFLAGS= -D warnings to the CI so all warnings are treated as hard errors.

Kerollmops
Kerollmops suggested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the title and commit message, please?
BTW, thank you, I had warnings when I was compiling...

@MarinPostma MarinPostma changed the title deny workings in CI deny warnings in CI Apr 21, 2022
@curquiza curquiza added the no breaking The related changes are not breaking (DB nor API) label Apr 21, 2022
@curquiza curquiza requested a review from Kerollmops April 25, 2022 16:50
Kerollmops
Kerollmops previously approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only say that I approve those changes but I am awaiting the fix of the CI to pass, a.k.a. removing the warnings.

@curquiza
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Apr 26, 2022
@bors
Try #507:
f8c98b4
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

try

Build succeeded:

@Kerollmops
Copy link
Member

Ok, so according to bors we can merge now!
bors merge

@bors
Copy link
Contributor

bors bot commented Apr 27, 2022

👎 Rejected by PR status

@curquiza
Copy link
Member

@Kerollmops or @MarinPostma could you rebase the PR before trying to merge?

@Kerollmops
Copy link
Member

Thank you marin!
bors merge

bors bot added a commit that referenced this pull request Apr 28, 2022
@bors @MarinPostma
Merge #507
a44d954 
507: deny warnings in CI r=Kerollmops a=MarinPostma

Add `RUSTFLAGS= -D warnings` to the CI so all warnings are treated as hard errors.

Co-authored-by: ad hoc <postma.marin@protonmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 28, 2022

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Kerollmops
Kerollmops approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 28, 2022

Build succeeded:

@bors bors bot merged commit 312515d into main Apr 28, 2022
@bors bors bot deleted the ci-deny-warnings branch April 28, 2022 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarinPostma @curquiza @Kerollmops