Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

First version of new CONTRIBUTING.md #508

Merged
merged 1 commit into from
Apr 25, 2022
Merged

First version of new CONTRIBUTING.md #508

merged 1 commit into from
Apr 25, 2022

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Apr 21, 2022

  • Add the new CONTRIBUTING.md, highly based on the same guideline as the Meilisearch and Tokenizer ones.
  • The "Development Workflow" section is WIP and should be improved but not in this PR. (I will open an issue once it's merge). However, if you see wrong information, please correct them 😇
  • I also updated the README accordingly. The README is the "What is it?" and the "How to use the library? (for the users, not the contributor/maintainers)" documentation. The CONTRIBUTING is the "How to contribute/maintain the repo?" documentation, so mostly for the core team and for every contributor. I will open an issue too once this PR is merged.

@curquiza curquiza requested a review from Kerollmops April 21, 2022 17:06
@curquiza curquiza added the no breaking The related changes are not breaking (DB nor API) label Apr 21, 2022
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est validax!

@Kerollmops
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

👎 Rejected by PR status

@Kerollmops Kerollmops merged commit 3e53791 into main Apr 25, 2022
@Kerollmops Kerollmops deleted the contributing branch April 25, 2022 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants