Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Deletion benchmarks #558

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Deletion benchmarks #558

merged 2 commits into from
Jun 16, 2022

Conversation

ManyTheFish
Copy link
Member

Add benchmarks on the deletion and start rethinking benchmark names.

@ManyTheFish ManyTheFish requested a review from irevoire June 16, 2022 08:34
@ManyTheFish ManyTheFish added no breaking The related changes are not breaking (DB nor API) maintenance Issue about maintenance (CI, tests, refacto...) labels Jun 16, 2022
irevoire
irevoire approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the factorization, the file was starting to get really large 👍

@ManyTheFish ManyTheFish marked this pull request as ready for review June 16, 2022 09:33
@ManyTheFish
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build succeeded:

@bors bors bot merged commit a59ae19 into main Jun 16, 2022
@bors bors bot deleted the deletion-benchmarks branch June 16, 2022 10:19
@irevoire irevoire added the performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption label Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) no breaking The related changes are not breaking (DB nor API) performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManyTheFish @irevoire