Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix deserialisation of NDJson documents in benchmarks #577

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix deserialisation of NDJson documents in benchmarks #577

merged 1 commit into from
Jul 5, 2022

Conversation

loiclec
Copy link
Contributor

@loiclec loiclec commented Jul 5, 2022

Previously, the first document in the NDJson file was read over and over again. So the geo_point benchmark was not working properly: it only indexed one document.

@loiclec loiclec requested a review from irevoire July 5, 2022 13:53
irevoire
irevoire approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loiclec 🐕
bors merge

@irevoire irevoire added bug Something isn't working skip changelog The PR will not appear in the release changelogs no breaking The related changes are not breaking (DB nor API) performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption benchmarks Related to the benchmarks labels Jul 5, 2022
@Kerollmops Kerollmops added skip changelog The PR will not appear in the release changelogs and removed skip changelog The PR will not appear in the release changelogs labels Jul 5, 2022
@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Build succeeded:

@bors bors bot merged commit 62692c1 into main Jul 5, 2022
@bors bors bot deleted the fix-ndjson-benchmarks branch July 5, 2022 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
benchmarks Related to the benchmarks bug Something isn't working no breaking The related changes are not breaking (DB nor API) performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption skip changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loiclec @irevoire @Kerollmops