Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Remove Bors required test for Windows #612

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Remove Bors required test for Windows #612

merged 1 commit into from
Aug 23, 2022

Conversation

curquiza
Copy link
Member

Remove the required windows test for merging due to the issue with Lindera
https://github.com/meilisearch/milli/runs/7970141278?check_suite_focus=true

@curquiza curquiza added no breaking The related changes are not breaking (DB nor API) maintenance Issue about maintenance (CI, tests, refacto...) labels Aug 23, 2022
@curquiza curquiza requested a review from Kerollmops August 23, 2022 09:46
Kerollmops
Kerollmops approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 23, 2022

Build succeeded:

@bors bors bot merged commit d0521e4 into main Aug 23, 2022
@bors bors bot deleted the windows-ci branch August 23, 2022 10:01
@curquiza curquiza mentioned this pull request Sep 7, 2022
Merged
bors bot added a commit that referenced this pull request Sep 7, 2022
@bors @curquiza
Merge #631
99b45a7 
631: Revert "Remove Bors required test for Windows" r=Kerollmops a=curquiza

Reverts #612

Because the issue does not seem to be there!

Closes #614

Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...) no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @Kerollmops