This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Optimise the ExactWords sub-criterion within Exactness
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclec
added
no breaking
loiclec
force-pushed
the
exactness-perf
branch
from
b786cfc to
712cf87
Compare
ManyTheFish
previously requested changes
Dec 14, 2022
There was a problem hiding this comment.
Hello @loiclec, nice PR,
I requested some small changes that can be discussed if you feel that there are not relevant,
Thanks!
8 tasks
1. Cache some results between calls to next() 2. Compute the combinations of exact words more efficiently
loiclec
force-pushed
the
exactness-perf
branch
from
712cf87 to
b5df889
Compare
irevoire
approved these changes
Jan 2, 2023
loiclec
dismissed
ManyTheFish’s stale review
Many is on holiday and can't re-review the PR. I applied his suggestions :)
|
Thank you! |
|
Build succeeded! And happy new year! 🎉
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes (partially) meilisearch/meilisearch#3116
What does this PR do?
exactnesscriterion.Performance Results
On the
smol_songs.csvdataset, a request containing 10 common words now takes about 60ms instead of 5 seconds to execute. For example, this is the case with this (admittedly nonsensical) request:Rock You Hip Hop Folk World Country Electronic Love The.